-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Expect scripts #6614
base: main
Are you sure you want to change the base?
Conversation
attempt to fix CI failure
ok I think I have the alphabetization right now
OK I think this is ready for review now; I don't think a new heuristic is necessary, since I don't see anything else using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think a new heuristic is necessary, since I don't see anything else using the
.exp
extension that would need to be distinguished from.
I just remembered that .exp
is sometimes used in test-suites to contain the expected output of a test run. It's usually paired with a file ending in .act
(to denote the actual output from a test), which is compared with the .exp
file using the diff(1) utility.
There also appear to be roughly ~203k search results for the .exp
extension that doesn't include lines beginning with set
or expect
. They don't appear to be fixtures for a test-suite either, so this might warrant a more in-depth investation.
sort tcl interpreters properly Co-authored-by: John Gardner <gardnerjohng@gmail.com>
Hm, so maybe just a really simple heuristic then? e.g. |
Actually, I was thinking However, generic extensions have the caveat that an accurate, airtight heuristic is needed, preferably one that matches a pattern or string that's all but guaranteed to appear in the files that we're interested in supporting. The regex I'm happy to help you with penning the regex, but that assumes there even is a predictable and guaranteed pattern unique to Expect scripts. |
Closes #6613
Description
Expect is an extension to the Tcl scripting language, so it can be categorized as Tcl. See #6613
Checklist: