Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix btoa context error #198

Merged
merged 3 commits into from
Jul 3, 2015
Merged

Conversation

firehist
Copy link
Contributor

@firehist firehist commented Jun 4, 2015

It resolves #196 . Just ensure that var atob in Github context coming from window.atob

@aendra-rininsland
Copy link
Member

Closing until passes tests and I can be convinced this is actually necessary. Please comment to reopen.

@firehist
Copy link
Contributor Author

Yes sorry, im so slow :p
I should never do as many things at the time.

@aendra-rininsland
Copy link
Member

@firehist No worries! Definitely know how that goes. 😄

Let me know once the tests are passing again and I'll take another look at it!

@firehist
Copy link
Contributor Author

Thanks a lot ;)
I'll.

@firehist
Copy link
Contributor Author

@Aendrew Tests pass locally, we can reopen PR.

@aendra-rininsland
Copy link
Member

@firehist Cool! Mind pushing your changes so Travis can run the tests? Thanks!

@firehist
Copy link
Contributor Author

Travis tests : https://travis-ci.org/michael/github/builds/68023787

BTW, if PR is closed, all my changes stack in my fork.
When you re-open PR, my commit 5d0c9a4 was visible and travis build test on that commit :)

@aendra-rininsland aendra-rininsland changed the title Fix atob context error Fix btoa context error Jun 25, 2015
@aendra-rininsland
Copy link
Member

@firehist Cool! LGTM — mind squashing your commits? Thanks! 👍

@firehist
Copy link
Contributor Author

I squashed my commits to remove my "trigger-commit" :)

aendra-rininsland pushed a commit that referenced this pull request Jul 3, 2015
@aendra-rininsland aendra-rininsland merged commit 3ab2732 into github-tools:master Jul 3, 2015
@aendra-rininsland
Copy link
Member

Apols for the delay! Merging! Thanks for the PR! 👍 :shipit:

@firehist
Copy link
Contributor Author

firehist commented Jul 4, 2015

No problem, results is merged 😄

@AndersDJohnson
Copy link
Contributor

+1 Will this fix be released to Bower?

@aendra-rininsland
Copy link
Member

@adjohnson916 I need to do a new release. For now, just do bower install github#master --save.

@firehist firehist deleted the fix/atob branch September 12, 2015 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atob is undefined depending on the call context
3 participants