-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix btoa context error #198
Conversation
Closing until passes tests and I can be convinced this is actually necessary. Please comment to reopen. |
Yes sorry, im so slow :p |
@firehist No worries! Definitely know how that goes. 😄 Let me know once the tests are passing again and I'll take another look at it! |
Thanks a lot ;) |
@Aendrew Tests pass locally, we can reopen PR. |
@firehist Cool! Mind pushing your changes so Travis can run the tests? Thanks! |
Travis tests : https://travis-ci.org/michael/github/builds/68023787 BTW, if PR is closed, all my changes stack in my fork. |
@firehist Cool! LGTM — mind squashing your commits? Thanks! 👍 |
I squashed my commits to remove my "trigger-commit" :) |
Fix btoa context error
Apols for the delay! Merging! Thanks for the PR! 👍 |
No problem, results is merged 😄 |
+1 Will this fix be released to Bower? |
@adjohnson916 I need to do a new release. For now, just do |
It resolves #196 . Just ensure that var
atob
in Github context coming fromwindow.atob