Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

call graphs in output contain spurious edges #93

Closed
kalexmills opened this issue Dec 25, 2020 · 1 comment · Fixed by #94
Closed

call graphs in output contain spurious edges #93

kalexmills opened this issue Dec 25, 2020 · 1 comment · Fixed by #94
Labels
bug Something isn't working vet-bot the issue is part of VetBot's responsibility

Comments

@kalexmills
Copy link
Contributor

kalexmills commented Dec 25, 2020 •
edited
Loading

The callgraph being reported in github-vet/rangeloop-pointer-findings#8083 has some strange edges, including a few outgoing edges from Atoi which make absolutely no sense. The repository does not contain any declaration bodies for Atoi so this seems impossible on its face.
@kalexmills kalexmills added bug Something isn't working vet-bot the issue is part of VetBot's responsibility labels Dec 25, 2020
@kalexmills
Copy link
Contributor Author

kalexmills commented Dec 25, 2020 •
edited
Loading

aaand this is what we'd expect if we were corrupting the callstack during the BFS;
It looks like that's what we're doing!
aren't slices fun?!

kalexmills added a commit that referenced this issue Dec 25, 2020
@kalexmills
fix: don't corrupt the stack during BFS;
05eeaf4 
closes #93
@kalexmills kalexmills mentioned this issue Dec 25, 2020
Merged
@kalexmills kalexmills mentioned this issue Dec 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working vet-bot the issue is part of VetBot's responsibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't corrupt the stack during BFS (please) github-vet/bots
1 participant
@kalexmills