Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multiple Production Environments #209

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Conversation

GrantBirki
Copy link
Member

Support Multiple Production Environments 🌍

This pull request enables support for multiple production environments. Before this change, the production_environment input value only accepted a single environment. This is not idea for projects that might do something like this:

  • .deploy production - Deploys code to the production environment
  • .deploy production-eu - Deploys code to a specialized European production environment (think, GDPR)

Since the production_environment input option only takes one value, we cannot set the production-eu environment as "production" via our API call to GitHub (happens inside of this Action for you). However, production-eu is absolutely a production environment, the name even says so!

To solve this, the production_environment input option will be removed and replaced with its plural counterpart -> production_environments (note the trailing s).

Breaking Change ⚠️

This will be a breaking change and warrant a new major release of this Action. If users are declaring production_environment in their config, it will absolutely need to be changed to production_environments when jumping to v8.0.0


closes: #208

@GrantBirki GrantBirki added the enhancement New feature or request label Sep 15, 2023
@GrantBirki GrantBirki self-assigned this Sep 15, 2023
@mnaser
Copy link

mnaser commented Sep 15, 2023

@GrantBirki it's up to you to deal with this from a maintenance point of view, but perhaps you could default production_environments to the value of production_environment with a warning that the value is deprecated, and then rip it out a few major release later (or avoid the major now).

For me, I don't mind :)

@GrantBirki
Copy link
Member Author

@mnaser I think it should be really easy for users to upgrade and hopefully folks will enjoy the added flexibility for the hassle of adding an s to their input opts 😉

I'll with the breaking release option here as I think it will all be okay!

@GrantBirki GrantBirki merged commit 82c238c into main Sep 15, 2023
4 checks passed
@GrantBirki GrantBirki deleted the production-environments branch September 15, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple production_environment
2 participants