This repository has been archived by the owner on Nov 14, 2019. It is now read-only.
log the actual bad key in case of an error in statsd_run_recvmmsg #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm afraid this change is not correct, since the underlying buffer will have been modified by the parse function. You will need to restore the |
|
Oh, i've added it and deployed on our servers. Works still fine :) |
vmg
pushed a commit
that referenced
this pull request
Jun 30, 2015
log the actual bad key in case of an error in statsd_run_recvmmsg
|
Thanks! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only "packet_drop" is logged. This is not very useful to find the actual bad key to fix it.