Test that only open licenses are included per CONTRIBUTING #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/github/choosealicense.com/blob/gh-pages/CONTRIBUTING.md#adding-a-license - check that all licenses have minimum permissions - remove non-open (and unused) forbiddens - closes #1 with confidence
| @@ -27,6 +27,22 @@ | |||
| expect(approved_licenses).to include(id), "See https://git.io/vzCTV." | |||
| end | |||
| end | |||
|
|
|||
| context "minimum permissions" do | |||
| permissions = license["permitted"] | |||
There was a problem hiding this comment.
I'll be honest, I don't fully get it, but stylistically, for tests, this should be let(:permissions) { license["permitted"] }, similar to the id line, a few lines above. It's a Ruby/Rspec thing and has something to do with scopes or cleanup, IIRC.
|
Really good idea. Two minor style notes, not to be too pedantic, but 👍. |
Merged
mlinksva
added a commit
that referenced
this pull request
Feb 9, 2016
Test that only open licenses are included per CONTRIBUTING
mlinksva
added a commit
that referenced
this pull request
Feb 28, 2016
should have been removed as part of #345 correct that oversight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/github/choosealicense.com/blob/gh-pages/CONTRIBUTING.md#adding-a-license