Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable Kotlin analysis in PR checks #1473

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Temporarily disable Kotlin analysis in PR checks #1473

merged 2 commits into from
Jan 10, 2023

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Jan 10, 2023 •
edited
Loading

Kotlin analysis is incompatible with Kotlin 1.8.0, which is now rolling out to the Actions runner images.

While we work on a more permanent fix to our PR checks, this will prevent us losing other test coverage.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer
Temporarily disable Kotlin analysis in PR checks
620a267 
Kotlin analysis is incompatible with Kotlin 1.8.0, which is now rolling
out to the Actions runner images.

While we work on a more permanent fix to our PR checks, this will
prevent us losing other
test coverage.
@henrymercer
Ensure we don't unset CODEQL_EXTRACTOR_JAVA_AGENT_DISABLE_KOTLIN
80b12d6
@henrymercer henrymercer marked this pull request as ready for review January 10, 2023 17:51
@henrymercer henrymercer requested a review from a team as a code owner January 10, 2023 17:51
aeisenberg
aeisenberg approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable for what we need. Did you create an issue to track this?

@henrymercer
Copy link
Contributor Author

Backlink added to internal issue :)

@henrymercer henrymercer merged commit f12f76f into dbartol/bundle-20230105 Jan 10, 2023
@henrymercer henrymercer deleted the henrymercer/temporarily-disable-kotlin-in-pr-checks branch January 10, 2023 19:49
This was referenced Jan 12, 2023
Merged
Merged
aeisenberg added a commit that referenced this pull request Oct 10, 2023
@aeisenberg
Re-enable kotlin tests
7feb9a0 
Reverts #1473
@aeisenberg aeisenberg mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @aeisenberg