-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add select_label
option
#12
Conversation
Would it be worth checking labels before CI or approvals, since label checks don't require additional API calls? |
I think that would be a great idea! Could save some compute and a bit of time when executing this Action |
You can either make the change in this PR or we can merge and you can implement on a fresh PR. Up to you! I reviewed the code and it all looks good to me. |
Thanks! I'll switch the order of checks in a new PR to keep changes small. 🚀 |
This PR adds the
select_label
option, which causescombine-pr
to ignore any PR that does not have a label matchingselect_label
.This will be useful in a few ways:
golang
withgo-dep
and PRs for Docker withdocker-dep
, then combine go changes together and docker changes together.Some notes on edge cases:
select_label
andignore_label
may be set. In this case, the PR is only combined if it has a label matchingselect_label
and does not have any label matchingignore_label
.select_label == ignore_label
, and error will be raise because it will be impossible for any PRs to be matched and this is almost certainly not what the developer intended.