Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document checks output.text field length #3765

Closed
ecksun opened this issue Feb 18, 2021 · 11 comments
Closed

Document checks output.text field length #3765

ecksun opened this issue Feb 18, 2021 · 11 comments
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team good first issue Good for newcomers help wanted Anyone is welcome to open a pull request to fix this issue rest Content related to rest - overview. triage Do not begin working on this issue until triaged by the team

Comments

@ecksun
Copy link

ecksun commented Feb 18, 2021

What article on docs.github.com is affected?

https://docs.github.com/en/rest/reference/checks#create-a-check-run

What part(s) of the article would you like to see updated?

The documentation for the field output.text should include that it is limited to 65535 characters

I have created a CI integration that reports output of my different stages as the text of a check run. When I got to one particular stage I got this error:

{
  "message": "Invalid request.\n\nOnly 65535 characters are allowed; 121090 were supplied.",
  "documentation_url": "https://docs.github.com/rest/reference/checks#create-a-check-run"
}

Which is fine for my usecase (I just have to decide which part of the output to include) but it would have been better had I known about the limitation beforehand instead of finding out a while later when my build output got big enough.

Additional information

@welcome
Copy link

welcome bot commented Feb 18, 2021

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 18, 2021
@janiceilene
Copy link
Contributor

Thanks for opening an issue @ecksun! I'll triage this for the team to take a look 👀

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team rest Content related to rest - overview. and removed triage Do not begin working on this issue until triaged by the team labels Feb 18, 2021
@janiceilene
Copy link
Contributor

@ecksun I've checked in with folks and it sounds like this would be a great addition to the docs! You or anyone else are welcome to open a PR ✨

@janiceilene janiceilene added good first issue Good for newcomers help wanted Anyone is welcome to open a pull request to fix this issue labels Feb 22, 2021
HeroicHitesh pushed a commit to HeroicHitesh/docs that referenced this issue Mar 22, 2021
Show maximum character limit of 65535 for `summary` and `text` fields of `output` object in `Checks` api
@janiceilene
Copy link
Contributor

I made a mistake in adding this issue to the "help wanted" column 💛 We'll need to make this fix internally since the majority of our REST documentation is generated from an internal repository.

I've made an internal issue for the writers to follow up on.

Thanks @ecksun for opening an issue and making us aware of the needed update!

@ecksun
Copy link
Author

ecksun commented Mar 31, 2021

I made a mistake in adding this issue to the "help wanted" column yellow_heart We'll need to make this fix internally since the majority of our REST documentation is generated from an internal repository.

Yeah, thats what I thought when I checked out the repo before creating the issue. There was a bunch of generated files but nothing that seemed to be the source.

Perhaps that could be mentioned somewhere in the repo?

Thanks @ecksun for opening an issue and making us aware of the needed update!

No problem :)

@janiceilene
Copy link
Contributor

Perhaps that could be mentioned somewhere in the repo?

🤔 I'll take that back to the team and figure out where it could live! If you have any thoughts on where it'd be helpful to see that information, please let me know 💖

@ecksun
Copy link
Author

ecksun commented Mar 31, 2021

If you have any thoughts on where it'd be helpful to see that information, please let me know

How about in CONTRIBUTING.md ?

@janiceilene
Copy link
Contributor

Oh my gosh, I didn't realize we never put it in there 🤦‍♀️ Thanks again @ecksun! We'll get something added in there.

@jsoref
Copy link
Contributor

jsoref commented Apr 9, 2021

@janiceilene: do you need an issue asking you to document that REST content is autogenerated and should not be modified by mortals on CONTRIBUTING.md ?

@janiceilene
Copy link
Contributor

@jsoref Sure! That would be really helpful, thank you 💖 Then anyone can open a PR to make the fix. It's been on my list of things to do all week, but I just haven't been able to prioritize it 😅

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 4, 2022
@docubot
Copy link
Contributor

docubot commented Jan 4, 2022

Thank you for opening this issue! Updates to the REST/GraphQL API description must be made internally. I have copied your issue to an internal issue, so I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team good first issue Good for newcomers help wanted Anyone is welcome to open a pull request to fix this issue rest Content related to rest - overview. triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@ecksun @jsoref @janiceilene @ramyaparimi @docubot and others