-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the table overflowing sidebar #1234
Conversation
Fixes github#1205 change current markup of table based on the previous fix with use of javascript/wrap-code-terms.js
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Thanks so much @SMAKSS! I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SMAKSS! Using <code>
tags here is a good change. 👍 And we agree the tables look better without the bold. Thanks for checking in about that!
One question I had about this... and we don't have to do it as part of this PR, but something to think about. If anything is bolded on the table, should it be the column headers? |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This comment was marked as spam.
This comment was marked as spam.
@SMAKSS I like the bold column titles :) |
PR Changes SummaryObjectiveThis PR aims to address an issue related to table overflow in the sidebar. It modifies the current markup of the table to use JavaScript to wrap code terms, thereby preventing overflow issues. Changes
Feel free to review the changes here. |
Fixes #1205
Changing the table markup in the Commit SHAs according to the previous fix which controls the overflow of the table with the use of javascript/wrap-code-terms.js.
Why:
Well, this PR will fix #1205 where the table has overflowed the sidebar like below:
What's being changed:
I tried to stick with the previous fix which fixes the #56 with the use of javascript/wrap-code-terms.js, so I just tried to change the current markup of the table. Since the current logic will only support the breaking of contents within a
<code>
tag I had to wrap the necessary items which cause them to overflow in the<code>
tag.So it will look like this:
But since the current style of the
<code>
tags within the table will make them bold I had to remove it from the general style to make the whole table look better, it may break changes in other pages (like this one) but I think they are overall looking good withoutfont-weight: bold;
but this is for owners to decide, so if there is any other suggestion to make it better I will be happy to make the necessary changes in the codebase.The final look of the table:
Check off the following: