Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead links #382

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Remove dead links #382

merged 2 commits into from
Oct 13, 2020

Conversation

7ze
Copy link
Contributor

@7ze 7ze commented Oct 10, 2020

Why:

Found an issue opened by Simran B regarding a few dead links.
Issue #344

What's being changed:

Removed a few dead links from the Table of Contents which appears to be outdated.

Check off the following:

@welcome
Copy link

welcome bot commented Oct 10, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Comment on lines -67 to -72
- [Resolving merge conflicts](#resolving-merge-conflicts)
- [In the GitHub user interface](#in-the-github-user-interface)
- [Editing the file and committing the changes](#editing-the-file-and-committing-the-changes)
- [Troubleshooting](#troubleshooting)
- [Failed status checks](#failed-status-checks)
- [Draft pull requests](#draft-pull-requests)
Copy link
Contributor Author

@7ze 7ze Oct 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any content to link these topics to. So ended up removing them as suggested by @janiceilene.
#344

Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @The-sad-philosopher! Thank you so much for fixing this up 💖 I'll update the branch and get this merged once all the tests are 🍏

@janiceilene janiceilene merged commit a375847 into github:main Oct 13, 2020
@janiceilene
Copy link
Contributor

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@7ze
Copy link
Contributor Author

7ze commented Oct 18, 2020

This looks great @The-sad-philosopher! Thank you so much for fixing this up sparkling_heart I'll update the branch and get this merged once all the tests are green_apple

@janiceilene Happy to help!
😊

@7ze
Copy link
Contributor Author

7ze commented Oct 18, 2020

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! sparkles

@all-contributors please add @The-sad-philosopher for doc

@janiceilene
Copy link
Contributor

I'm so sorry @The-sad-philosopher! We had to remove all contributors because our small team wasn't able to keep up with the influx of contributions 💛 More details are available in #576.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants