Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repairing .allcontributorsrc #391

Closed
wants to merge 2 commits into from
Closed

Repairing .allcontributorsrc #391

wants to merge 2 commits into from

Conversation

Protectator
Copy link
Contributor

@Protectator Protectator commented Oct 10, 2020

Why:

The current .allcontributorsrc file contains an error and isn't valid JSON.

What's being changed:

This PR repairs the .allcontributorsrc file.

Check off the following:

Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, thanks @Protectator! I'll get this branch updated and merge once the tests are green 🍏

@janiceilene
Copy link
Contributor

👋 @Protectator Turns out there were more issues than just this one with the all contributors file. The tests didn't finish before I logged off last night and someone else opened a PR that fixed this problem and a few others in the files 🙈 So I'm going to close this. Thank you so much!

If you haven't already, do you want to try and add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@Protectator
Copy link
Contributor Author

Sure, thanks for the feedback. So trying again this time :

@all-contributors please add @Protectator for content

@allcontributors
Copy link
Contributor

@Protectator

I've updated the pull request to add @Protectator! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants