Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed slash in "if" and minor formatting #508

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Missed slash in "if" and minor formatting #508

merged 3 commits into from
Oct 16, 2020

Conversation

Roog
Copy link
Contributor

@Roog Roog commented Oct 14, 2020 •
edited
Loading

Hi!
Some suggested changes. Hope you like it!

These links seems broken?!:

Why:

Missed a "/"-slash in URL configuration reference

What's being changed:

  • Installing packages from ither organizations had a missplaced slash "/" for the IF
  • Missed two quotes on see "Installing packages...organizations"
  • Intendention on "publishConfig" was not aligned

Check off the following:

@Roog
Missed slash in "if" and minor formatting
07eba29 
- Installing packages from ither organizations had a missplaced slash "/" for the IF
- Missed two quotes on see "Installing packages...organizations"
- Intendention on "publishConfig" was not aligned
@welcome
Copy link

welcome bot commented Oct 14, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thank you so much for this PR @Roog! I'll get this triaged for review ⚡

@janiceilene janiceilene added ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team content This issue or pull request belongs to the Docs Content team packages This issue or pull request should be reviewed by the docs packages team labels Oct 15, 2020
rachmari
rachmari reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@rachmari rachmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Roog thank you so much for finding and fixing this bug! 🙌 Also thank you for aligning the other changes with our style guide. 💚:octocat: This is great. I had one super tiny comment, but as soon as that is fixed, I'll get this merged! 🚀

...github-packages-with-your-projects-ecosystem/configuring-npm-for-use-with-github-packages.md Outdated Show resolved Hide resolved
@rachmari rachmari self-assigned this Oct 15, 2020
@Roog @rachmari
Update content/packages/using-github-packages-with-your-projects-ecos…
a78119e 
…ystem/configuring-npm-for-use-with-github-packages.md

Co-authored-by: Rachael Sewell <rachmari@github.com>
@rachmari rachmari merged commit 56ffb1f into github:main Oct 16, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@snyk-bot snyk-bot mentioned this pull request Jul 7, 2022
Open
@montana910318 montana910318 mentioned this pull request Jul 7, 2022
Open
@treeations treeations mentioned this pull request Jul 7, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 7, 2022
Open
@strezless strezless mentioned this pull request Jul 7, 2022
Open
@muratkalenderoglu muratkalenderoglu mentioned this pull request Jul 7, 2022
Open
This was referenced Jul 7, 2022
Open
Open
@shga1993 shga1993 mentioned this pull request Jul 7, 2022
Open
@ramsemune ramsemune mentioned this pull request Jul 7, 2022
Open
This was referenced Jul 7, 2022
Open
Open
Open
Open
@Oleksandr1201vsp Oleksandr1201vsp mentioned this pull request Jun 24, 2023
Open
@w124578 w124578 mentioned this pull request Jun 24, 2023
Open
@chrisjcox79 chrisjcox79 mentioned this pull request Jun 24, 2023
Open
@treeations treeations mentioned this pull request Jun 24, 2023
Open
@mitrostziavarasgr mitrostziavarasgr mentioned this pull request Jun 24, 2023
Open
@dotam99 dotam99 mentioned this pull request Jun 24, 2023
Open
@pinpc pinpc mentioned this pull request Jun 24, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jun 24, 2023
Open
@dev2dark dev2dark mentioned this pull request Jun 24, 2023
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Jun 24, 2023
Open
@989919259920 989919259920 mentioned this pull request Jun 24, 2023
Open
@Visva92 Visva92 mentioned this pull request Jun 24, 2023
Open
@francissimo francissimo mentioned this pull request Jun 24, 2023
Open
@kabat87 kabat87 mentioned this pull request Jun 25, 2023
Open
@B020239 B020239 mentioned this pull request Jun 30, 2023
Open
@ryan-ally ryan-ally mentioned this pull request Nov 15, 2023
Open
@Anmar1988260 Anmar1988260 mentioned this pull request Nov 30, 2023
Open
@montana910318 montana910318 mentioned this pull request Nov 30, 2023
Open
@makombelajob makombelajob mentioned this pull request Nov 30, 2023
Open
@qmutz qmutz mentioned this pull request Nov 30, 2023
Open
@oudomskn oudomskn mentioned this pull request Nov 30, 2023
Open
@Visva92 Visva92 mentioned this pull request Nov 30, 2023
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Dec 1, 2023
Open
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Dec 1, 2023
Open
@ryan-ally ryan-ally mentioned this pull request Dec 27, 2023
Open
@aliscco aliscco mentioned this pull request Dec 28, 2023
Open
@avengerfart avengerfart mentioned this pull request Dec 28, 2023
Open
@aliscco aliscco mentioned this pull request Jan 5, 2024
Open
@ryan-ally ryan-ally mentioned this pull request Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachmari rachmari rachmari approved these changes

Assignees

@rachmari rachmari

Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Roog @janiceilene @rachmari