Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove counter-related code. #75

Merged
merged 3 commits into from
Jun 9, 2023
Merged

chore: remove counter-related code. #75

merged 3 commits into from
Jun 9, 2023

Conversation

khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Jun 8, 2023

Fixes: #74

This PR completely removes the counter-system related code, which was moved to deprecation status in v0.2.0.

We've supported enabling the counter system on a per rule basis to ease migration but now that we're a few versions in, let's completely deprecate it.

@khiga8 khiga8 marked this pull request as ready for review June 8, 2023 22:35
@khiga8 khiga8 requested a review from a team as a code owner June 8, 2023 22:35
@accessibility-bot
Copy link

👋 Hello and thanks for pinging us! You've entered our first responder queue. An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

@khiga8 khiga8 changed the title Remove counter-related code. chore: remove counter-related code. Jun 8, 2023
Copy link
Contributor

@JoyceZhu JoyceZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting a bunch of code, nice

@khiga8 khiga8 merged commit 30ee192 into main Jun 9, 2023
@khiga8 khiga8 deleted the kh-remove-counter-code branch June 9, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: completely deprecate counter system
3 participants