Temporarily introduce back counter_correct? helper #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily introduces back the
counter_correct?helper which was removed in a recent PR.One of our project pulls in both
erblint-githubandprimer_view_components. The latter has a custom rule which pulls in thecounter_correct?helper from this gem.This means that projects that use
primer_view_componentsare blocked on upgradingerblint_githubdue to the lint rule inprimer_view_componentsdepending on thiscounter_correct?helper.I've since removed the dependency on
erblint-githubfromprimer_view_componentsin primer/view_components#2067, but until there's a new version ofprimer_view_componentsfor consumers, I'd like to temporarily keep this custom helper in this gem.