Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ensure recommended setup works #80

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Add test to ensure recommended setup works #80

merged 1 commit into from
Jun 14, 2023

Conversation

khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Jun 14, 2023 •
edited
Loading

This PR adds test coverage for the setup that we recommend in our README.

@khiga8 khiga8 marked this pull request as ready for review June 14, 2023 13:25
@khiga8 khiga8 requested a review from a team as a code owner June 14, 2023 13:25
@accessibility-bot
Copy link

👋 Hello and thanks for pinging us! You've entered our first responder queue. An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

smockle
smockle approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@smockle smockle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that there are indeed 15 enabled rules in config/accessibility.yml, and that the test file will run (because its name ends with _test). 👍

@khiga8 khiga8 merged commit 501b2cd into main Jun 14, 2023
@khiga8 khiga8 deleted the kh-add-test-for-setup branch June 14, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smockle smockle smockle approved these changes

@accessibility-bot accessibility-bot Awaiting requested review from accessibility-bot accessibility-bot is a code owner automatically assigned from github/accessibility-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khiga8 @accessibility-bot @smockle