Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accessibility.yml recommended configs. #81

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Jun 16, 2023

The NoUnusedDisable rule should be on by default in our recommended configs.

This rule flags when a disable comment is no longer necessary.

@khiga8 khiga8 requested a review from a team as a code owner June 16, 2023 18:27
Copy link
Contributor

@smockle smockle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! 🚀

Incidentally, we don’t need to update the recently-added “recommended_setup_works_test”, because it only looks for rules with GitHub::Accessibility:

assert_equal 15, rules_enabled_in_accessibility_config
assert_equal 15, known_linter_names.count { |linter| linter.include?("GitHub::Accessibility") }

@khiga8 khiga8 merged commit e4646f0 into main Jun 16, 2023
@khiga8 khiga8 deleted the kh-no-unused-disable-is-on-by-default branch June 16, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants