Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from = 1.52.1 to = 1.53.0 #84

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 26, 2023

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.53

New features

Bug fixes

  • #11953: Fix a false negative for Lint/DuplicateHashKey when there is a duplicated constant key in the hash literal. (@​koic)
  • #11945: Fix a false negative for Style/RedundantSelfAssignmentBranch when using method chaining or arguments in ternary branch. (@​koic)
  • #11949: Fix a false positive for Layout/RedundantLineBreak when using a line broken string. (@​koic)
  • #11931: Fix a false positive for Lint/RedundantRequireStatement when using PP.pp. (@​koic)
  • #11946: Fix an error for Lint/NumberConversion when using multiple number conversion methods. (@​koic)
  • #11972: Fix an error for Lint/Void when CheckForMethodsWithNoSideEffects: true and using a method definition. (@​koic)
  • #11958: Fix error for Style/IdenticalConditionalBranches when using empty parentheses in the if branch. (@​koic)
  • #11962: Fix an error for Style/RedundantStringEscape when an escaped double quote precedes interpolation in a symbol literal. (@​koic)
  • #11947: Fix an error for Style/ConditionalAssignment with an assignment that uses if branch bodies, which include a block. (@​koic)
  • #11959: Fix false negatives for Layout/EmptyLinesAroundExceptionHandlingKeywords when using Ruby 2.5's rescue inside block and Ruby 2.7's numbered block. (@​koic)
  • #10902: Fix an error for Style/RedundantRegexpEscape string with invalid byte sequence in UTF-8. (@​ydah)
  • #11562: Fixed escaped octal handling and detection in Lint/DuplicateRegexpCharacterClassElement. (@​rwstauner)

Changes

Changelog

Sourced from rubocop's changelog.

1.53.0 (2023-06-23)

New features

Bug fixes

  • #11953: Fix a false negative for Lint/DuplicateHashKey when there is a duplicated constant key in the hash literal. ([@​koic][])
  • #11945: Fix a false negative for Style/RedundantSelfAssignmentBranch when using method chaining or arguments in ternary branch. ([@​koic][])
  • #11949: Fix a false positive for Layout/RedundantLineBreak when using a line broken string. ([@​koic][])
  • #11931: Fix a false positive for Lint/RedundantRequireStatement when using PP.pp. ([@​koic][])
  • #11946: Fix an error for Lint/NumberConversion when using multiple number conversion methods. ([@​koic][])
  • #11972: Fix an error for Lint/Void when CheckForMethodsWithNoSideEffects: true and using a method definition. ([@​koic][])
  • #11958: Fix error for Style/IdenticalConditionalBranches when using empty parentheses in the if branch. ([@​koic][])
  • #11962: Fix an error for Style/RedundantStringEscape when an escaped double quote precedes interpolation in a symbol literal. ([@​koic][])
  • #11947: Fix an error for Style/ConditionalAssignment with an assignment that uses if branch bodies, which include a block. ([@​koic][])
  • #11959: Fix false negatives for Layout/EmptyLinesAroundExceptionHandlingKeywords when using Ruby 2.5's rescue inside block and Ruby 2.7's numbered block. ([@​koic][])
  • #10902: Fix an error for Style/RedundantRegexpEscape string with invalid byte sequence in UTF-8. ([@​ydah][])
  • #11562: Fixed escaped octal handling and detection in Lint/DuplicateRegexpCharacterClassElement. ([@​rwstauner][])

Changes

Commits
  • 80485d2 Cut 1.53
  • f6bac40 Update Changelog
  • f23bd40 [Fix #11972] Fix an error for Lint/Void
  • 04ea207 Fix a false positive for Lint/RedundantRequireStatement
  • 273f9bd Revert "Change include paths to be relative to working directory rather than ...
  • 1ed69f8 Add new Style/ReturnNilInPredicateMethodDefinition cop
  • 0c5c4fc Remove a useless style guide URL
  • 766e208 Mark Layout/ClassStructure as unsafe to autocorrect
  • 1e2d84a Merge pull request #11940 from iMacTia/fix/lint-missing-super-configurable-st...
  • 09d0ff5 [Fix #8506] Add AllowedParentClasses config to Lint/MissingSuper.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.52.1...v1.53.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner June 26, 2023 04:04
@dependabot dependabot bot added ospo-dependency-license-alert Issue created by dependency license check ruby Pull requests that update Ruby code labels Jun 26, 2023
@lindseywild
Copy link
Contributor

It looks like the new Style/ReturnNilInPredicateMethodDefinition rule caused lint to fail, I updated to return false per the suggestion given and CI passed!

Copy link
Contributor

@kendallgassner kendallgassner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine since we arent using the value!

@lindseywild lindseywild merged commit 5e1889f into main Jun 27, 2023
@lindseywild lindseywild deleted the dependabot/bundler/rubocop-1.53.0 branch June 27, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ospo-dependency-license-alert Issue created by dependency license check ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants