Create rule: no-visually-hidden-interactive-element #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindseywild
reviewed
Jul 21, 2023
Comment on lines
27
to
33
| <h2 className="sr-only">Welcome to GitHub</h2> | ||
| ``` | ||
|
|
||
| 👍 Examples of **correct** code for this rule: | ||
|
|
||
| ```jsx | ||
| <h2 className="sr-only">Welcome to GitHub</h2> |
There was a problem hiding this comment.
These are the same example 🤔
kendallgassner
commented
Jul 21, 2023
docs/rules/accessibility/no-visually-hidden-interactive-elements.md
Outdated
Show resolved
Hide resolved
….com/github/erblint-github into add_visually_hidden_interactive_rule
lindseywild
approved these changes
Jul 21, 2023
kendallgassner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This rule checks that interactive elements are not visually hidden.
Visually hiding content can be useful when you want to provide information specifically to screen reader users or other assistive technology users while keeping content hidden from sighted users.
How this differs from the eslint rule
asprop since erb files do not have anaspropsr-onlyclass.