Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Add EventListener interface support #13

Merged
merged 1 commit into from
May 7, 2019
Merged

Add EventListener interface support #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ var enhance = module.exports = function enhance(proto) {
return originalAddEventListener.call(this, name, originalCallback, optionsOrCapture)
}

var callback = originalCallback
var callback = typeof originalCallback !== 'function' && typeof originalCallback.handleEvent === 'function' ? originalCallback.handleEvent.bind(originalCallback) : originalCallback
var options = typeof optionsOrCapture === 'boolean' ? {capture: optionsOrCapture} : optionsOrCapture || {}
var passive = Boolean(options.passive)
var once = Boolean(options.once)
Expand Down
30 changes: 23 additions & 7 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,20 @@ require('core-js/es6/weak-map')
var polyfillEventTarget = require('../src')
var assert = require('assert')

function testSuite(eventTarget) {
function testSuite(eventTarget, listenerType) {
return function() {
var i = 0
function increment() { i += 1 }
var listeners = {
'Function': function() { i++ },
'EventListener': { handleEvent: function() { i++ } },
'Ambiguous': (function() {
function listener() { i++ }
listener.handleEvent = function() {}
return listener
})()
}
var increment = listeners[listenerType]

function event(name) {
var ev = document.createEvent("CustomEvent")
ev.initCustomEvent(name, false, false, null)
Expand Down Expand Up @@ -200,15 +210,21 @@ function testSuite(eventTarget) {
}
}

describe('Window add/removeEventListener', testSuite(window))
['Function', 'EventListener', 'Ambiguous'].forEach(function(listenerType) {
describe(listenerType + ' listener', function() {

describe('Window add/removeEventListener', testSuite(window, listenerType))

describe('Document add/removeEventListener', testSuite(document))
describe('Document add/removeEventListener', testSuite(document, listenerType))

describe('Div add/removeEventListener', testSuite(document.createElement('div')))
describe('Div add/removeEventListener', testSuite(document.createElement('div'), listenerType))

describe('TextNode add/removeEventListener', testSuite(document.createTextNode('testing')))
describe('TextNode add/removeEventListener', testSuite(document.createTextNode('testing'), listenerType))

describe('XHR add/removeEventListener', testSuite(new XMLHttpRequest(), listenerType))
})
})

describe('XHR add/removeEventListener', testSuite(new XMLHttpRequest()))

describe('Manual Polyfill', function() {

Expand Down