Add collation settings to allow collation to override charset #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latentflip
reviewed
Jan 23, 2023
… host'; both are acceptable responses
latentflip
previously approved these changes
Jan 23, 2023
| @@ -51,8 +51,8 @@ func TestProxySQLGetDB(t *testing.T) { | |||
| if err == nil { | |||
| t.Fatal("expected error for failed connection") | |||
| } | |||
| if !strings.HasSuffix(err.Error(), "no such host") { | |||
| t.Fatalf("expected a 'no such host' error, got %v", err) | |||
| if !strings.HasSuffix(err.Error(), "no such host") && !strings.HasSuffix(err.Error(), "i/o timeout") { | |||
There was a problem hiding this comment.
Is this change meant to be in this PR?
There was a problem hiding this comment.
This is to fix a test failure when run in Actions, as the invalid host lookup now times out instead of returning "no such host" (but the important thing for this test is that connecting to an invalid hostname fails, which is still the case with this change). I've not dug further into why this has changed.
Good shout - done 👍 There is a lot of logic driven from |
latentflip
approved these changes
Jan 25, 2023
TeeKraken
approved these changes
Jan 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new settings:
ConfigurationSettings->BackendCollation- if specified, setscollation=?in the DSN for the backend MySQL database connection, replacing the defaultcharset=utf8mb4,utf8,latin1settingMySQLConfigurationSettings->Collation- if specified, setscollation=?in the DSN for the monitored MySQL stores connections, replacing the defaultcharset=utf8mb4,utf8,latin1settingWhen these values are set to a charset that is common between MySQL 5.7 and 8.0 (e.g.
utf8mb4_unicode_520_ci), this prevents Freno from breaking temporary replication from an 8.0 primary to a 5.7 replica.This PR does not change the existing behaviour of Freno (i.e. setting
charset=utf8mb4,utf8,latin1); instead it allows the existing behaviour to be overriden when the new collation settings are specified.I have not added the new collation parameters to the documentation as they are for a niche use case.
Also in this PR: