Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set IgnoreHostsThreshold in ClusterProbe #166

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Set IgnoreHostsThreshold in ClusterProbe #166

merged 2 commits into from
Apr 9, 2024

Conversation

meiji163
Copy link
Contributor

@meiji163 meiji163 commented Apr 9, 2024

The IgnoreHostsThreshold in the cluster probe was not getting set to the value from the config when the cluster is using Vitess or ProxySQL.
This causes IgnoreHostsCount hosts to be ignored regardless of what the configured IgnoreHostsThreshold value is.

@meiji163 meiji163 requested review from rashiq and dm-2 April 9, 2024 01:04
rashiq
rashiq approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@rashiq rashiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@meiji163 meiji163 temporarily deployed to production/github-mysqlutil April 9, 2024 14:59 Inactive
@meiji163 meiji163 temporarily deployed to production/github-mysqlutil April 9, 2024 15:13 Inactive
@meiji163 meiji163 merged commit d89b112 into master Apr 9, 2024
4 checks passed
@meiji163 meiji163 deleted the meiji163/debug branch April 9, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dm-2 dm-2 dm-2 approved these changes

@rashiq rashiq rashiq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meiji163 @rashiq @dm-2