Safely transliterate international characters for aliases #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing because of lack of support of end of life ruby versions before 2.3 from the i18n library (2.2. was EOL more than 2 years ago now, so not an unreasonable policy). I can probably fix this, but it'll be a less than ideal solution. Give me a shout if you'd like to continue maintaining support for the older versions, and I'll see what I can do. |
koddsson
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
This is failing because of lack of support of end of life ruby versions before 2.3 from the i18n library (2.2. was EOL more than 2 years ago now, so not an unreasonable policy).
I think it's reasonable to not support ruby versions < 2.3 given that they are all EOL. Interested in hearing what @mislav thinks.
mislav
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we encounter an international character (from the perspective of someone in the USA, or UK), we replace it with an underscore (_)
This isn't ideal because it means words like piñata become pi_ata. There's a good way to transliterate these characters into their ASCII character range representation using the i18n library.
This will take the excellent detective work done by @stone-zeng and use that to create a fix.
Relates to: #180