[Schema Consistency] Schema Consistency Check — 2026-10-25: three safe-output contract mismatches

[github-actions[bot]]

🔍 Schema Consistency Check — 2026-10-25

Three confirmed inconsistencies affect copyable reference examples. No critical runtime defect was established. Repository source files were left unchanged.

Summary

• Inconsistencies found: 3 (one affects two close operations).
• Categories analyzed: schema, parser/compiler, documentation, repository workflows/shared components.
• Strategy: Safe-output example contract triangulation; new exploration strategy (day 298 modulo 10 = 8).
• Verification: local Draft7 validation of isolated configuration objects plus static compiler and handler inspection. No workflow code was executed.

Key Issues

1. Schema rejects implemented close-operation body controls. close-issue.allow-body and close-discussion.allow-body are documented but absent from their schema property lists. Both reject {"allow-body": false} with additionalProperties. This blocks the documented option for suppressing closing comments. Add boolean properties to both schema branches.
2. PR review comments document an unsupported footer option. The reference advertises footer: "if-body", but the schema rejects it and the compiler configuration has no footer field or parser assignment. Remove the example option unless support is intentionally implemented across the configuration and handler contract.
3. Release-update token override is implemented and documented but schema-rejected. update-release.github-token is absent from the schema, even though the compiler parses its shared base configuration and the release handler serializes the token. Add the token property consistently with other safe outputs.

Evidence, scope, and limitations

Schema Improvements Needed / Parser Updates Required

Finding 1: pkg/parser/schemas/main_workflow_schema.json, JSON pointers /properties/safe-outputs/properties/close-issue/oneOf/0/properties and /properties/safe-outputs/properties/close-discussion/oneOf/0/properties, omit allow-body. Documentation: docs/src/content/docs/reference/safe-outputs.md:399 and :1346. Implementation: pkg/workflow/close_entity_helpers.go:87 defines AllowBody *bool with the YAML tag; the shared close parser unmarshals the configuration. pkg/workflow/safe_outputs_handler_registry_issues.go:50 serializes allow_body. Preserve this existing implementation and align schema acceptance.

Finding 2: docs/src/content/docs/reference/safe-outputs-pull-requests.md:292 includes footer: "if-body". Schema pointer /properties/safe-outputs/properties/create-pull-request-review-comment/oneOf/0/properties omits it. pkg/workflow/create_pr_review_comment.go:10 defines the config fields and its parser without a footer option. This is a documentation gap relative to both schema and compiler.

Finding 3: docs/src/content/docs/reference/safe-outputs.md:1156 includes github-token. Schema pointer /properties/safe-outputs/properties/update-release/oneOf/0/properties omits it. pkg/workflow/update_release.go:10 embeds UpdateEntityConfig; pkg/workflow/update_entity_helpers.go:94 embeds the base safe-output configuration and :167 invokes its parser. pkg/workflow/safe_outputs_handler_registry_releases.go:12 passes the resolved token.

Each isolated object was validated against its actual object branch and produced exactly the corresponding unexpected-property error. Full documentation fragments were not treated as standalone workflows: missing on in partial examples and Kubernetes configuration were excluded. Previously cached findings were excluded from this report.

Workflow Violations

The precomputed diff reports no top-level workflow keys outside the schema. A targeted scan of 464 frontmatter-bearing Markdown files under .github/workflows, including shared components, found no use of these four affected nested keys. No workflow violation is asserted. This is not a full compile or imported-workflow validation.

The two apparent top-level field gaps are false positives: docker-image-pull-policy and work-queue-policy have RawFrontmatter consumers (pkg/workflow/docker.go:294 and pkg/workflow/work_queue_policy.go:184).

Non-authoritative AWF Warning

The precomputed AWF comparison has degraded: true: canonical-source retrieval failed. AWF drift cannot be established from this comparison. No required check failure, corrective PR, or drift issue is proposed from that incomplete data.

Recommendations and Next Steps

• Add schema acceptance for allow-body on both close operations and for update-release.github-token.
• Remove the unsupported PR review comment footer example, or implement and document an explicit contract.
• Add focused regression coverage validating these documentation examples against the schema.
• Recompile representative workflows after fixes; no existing workflow edit is indicated by this scan.

Strategy Performance

• Findings: 3; effectiveness: high; should reuse: yes.
• Combining isolated schema validation with compiler tracing separated missing schema properties from unsupported documentation claims. Strategy results were saved to the strategy cache.

References: §40165736357

Generated by ✅ Schema Consistency Checker · codex · gpt61 · ~16 AIC · ⌖ ~7 AIC · ⊞ 19.6K · ◷

• expires on Oct 25, 2026, 9:35 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by Schema Consistency Checker.

A newer discussion is available at Discussion #72017.