Repository navigation
[Schema Consistency] 🔍 Schema Consistency Check - 2026-11-01 #73715
Closed
Replies: 1 comment
|
This discussion has been marked as outdated by Schema Consistency Checker. A newer discussion is available at Discussion #74042. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Overview
Found 3 confirmed inconsistencies across documentation, schema, and compiler contracts. Reviewed all four areas, including a targeted scan of 470 workflow/shared frontmatter blocks. No occurrences of the three affected patterns were found in that scan. Source files were unchanged.
Key Issues
docs/src/content/docs/reference/faq.md:224nestsmcp-serversundertoolsand usesimage. The schema rejects the nested key. Its supported server field iscontainer. Fix: movemcp-serversto the top level and replaceimagewithcontainer, retaining the domain allowlist.docs/src/content/docs/reference/mcp-gateway.md:1617describes label-based demotion and examples at lines 1625 and 1636 configuretools.github.refusal-labels. The schema rejects that field; compiler guard construction serializes blocked users, trusted users, and approval labels, with no refusal-labels path found. Fix: clearly mark this contract as unavailable in the current authoring interface, or implement schema acceptance, parsing, validation, and policy forwarding together. This is a static configuration-contract finding; runtime gateway enforcement was not tested.docs/src/content/docs/reference/sandbox.md:115showsnetwork.firewall: true, which the schema rejects. Fix: remove that line while retainingsandbox.agent: awfand the existingnetwork.allowedentries. The corrected fragment passes local schema constraints. This finding uses the local frontmatter schema, not the unavailable canonical AWF config source.Critical Issues
No critical runtime bug established. The refusal-labels documentation mismatch deserves priority because it describes a policy control that users cannot configure through the documented example.
Evidence, validation, and coverage
Schema and Parser Evidence
pkg/parser/schemas/main_workflow_schema.json:4934; tools properties: line 4966. The compiler merges separately supplied top-level MCP servers inpkg/workflow/tools.go:443. A minimal rejected FAQ fragment becomes schema-valid after moving the block and usingcontainer.pkg/parser/schemas/main_workflow_schema.json:5188; parsing atpkg/workflow/tools_parser.go:345; typed approval labels atpkg/workflow/tools_types.go:445; emitted policy fields atpkg/workflow/mcp_github_config.go:497. A minimal min-integrity plus refusal-labels fragment fails with an unexpected-property error. The min-integrity-only baseline passes; removing refusal-labels is a validation control, not an equivalent policy replacement.pkg/parser/schemas/main_workflow_schema.json:3947.pkg/workflow/engine.go:187has an internal FirewallConfig pointer, which does not establish support for the documented public boolean syntax. Removing only the obsolete boolean makes the fragment pass local schema constraints.Validation Method
Used inert Python YAML parsing and local Draft7 JSON Schema validation only. Three minimal bad fragments failed; three corrected or baseline fragments passed local constraints. Root required-field errors were excluded for these partial fragments, so these are not claims of full compilation success. No workflow code was executed.
Workflow Violations
No selected-pattern occurrences in 470 parsed frontmatter blocks under
.github/workflows/, including shared components. The precomputed diff also reports no used top-level keys absent from the schema. Neither result establishes full workflow validity.Leads Ruled Out
The precomputed
docker-image-pull-policyandwork-queue-policytyped-field gaps are not confirmed bugs: raw-frontmatter consumers exist atpkg/workflow/docker.go:294andpkg/workflow/work_queue_policy.go:184. Previously cached findings were excluded from this report.AWF Comparison Warning — Non-authoritative
/tmp/gh-aw/agent/awf-config-drift.jsonreportsdegraded: truebecause canonical source retrieval failed. No authoritative config-source drift conclusion is possible. No required check failure, corrective PR, or drift issue is proposed from that incomplete comparison.Recommendations and Next Steps
Strategy Performance
Strategy: Schema-def spot checks + targeted parser/doc/workflow verification (proven strategy-2). New strategy: No. Day 305 modulo 10 = 5 selected reuse. Findings: 3. Effectiveness: High. Should reuse: Yes. Updated the strategy cache with these findings and bounded validation results.
References: §41276757586
All reactions