Implementation for issue #4 #37
Conversation
|
This also addresses issue #35 |
|
Hi @shanep, Thanks for this contribution! We agree that a single-command solution to downloading all student submissions is in the best interest for teachers. Our team is currently working on auditing the relevant API endpoints to ensure that we can scale with this new interface! |
There was a problem hiding this comment.
Thanks for this contribution! We agree that a single-command solution to downloading all student submissions is in the best interest for teachers. Our team is currently working on auditing the relevant API endpoints to ensure that we can scale with this new interface!
@RyanHecht I think these changes (with a few modifications) can be a great interim fix to the problem that teachers are facing.
I've left some comments above for @shanep that we can hopefully resolve in order to get these changes approved! Thank you for your hard work on this PR ✨
Co-authored-by: Zenara Daley <zrdaley@github.com>
shanep
force-pushed
the
clone-all-repos
branch
from
4f53215
to
5190eae
Compare
pkg/classroom/http.go is only meant to contain API calls. modified: cmd/gh-classroom/accepted-assignments/accepted_assignments.go modified: cmd/gh-classroom/clone/student-repos/student-repos.go modified: cmd/gh-classroom/shared/shared.go modified: pkg/classroom/http.go modified: pkg/classroom/http_test.go
shanep
force-pushed
the
clone-all-repos
branch
from
5190eae
to
6db9e64
Compare
What are you trying to accomplish?
Implementation for issue #4
Downloading all the student repo is now the default behavior. All the original functionality such as downloading per page still exists. In almost all cases that I can think of an instructor or TA/LA wants all the assignments for a class so by default this feature is enabled and must be explicitly turned off to got back to the original.
What approach did you choose and why?
I added a new function and associated tests to get all the assignments. The new function simply calls the rest API in a loop until it receives no more input.
What should reviewers focus on?
I haven't written much go code so any feedback is appreciated :)