-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binlogstreamer.go:47: [error] close sync with err: sync is been closing... #597
Comments
You may either use |
thanks shlomi-noach |
It looks like v1.0.46 included this fix? I am still noticing this in our environment. I have been testing this on our replica with
Script:
Error:
|
I am noticing this in our environment ... |
Can also reproduce this:
|
I see, thanks for the follow-up. I will try letting it run and see how it goes. |
It seems to have eventually errored after leaving it to run:
|
@peppy which version are you running? and which MySQL version? |
|
I'm seeing the exact same issue with gh-ost version 1.0.47 and mysql 8.0.11. I have tested in both RDS and dbdeployer. Here's my command line and a log snippet for dbdeployer: The same gh-ost version and parameters work fine for mysql 5.7.x in both RDS and dbdeployer, so I think it must be something peculiar to mysql 8. I thought perhaps it might be the log_bin_use_v1_row_events setting, but I've tested with that either way with the same error(s). Any other info I can provide to help troubleshoot this? Thanks, |
I'm merely guessing that |
Same error on 1.0.47: [root@node1 vagrant]# gh-ost --version gh-ost --user=root --database employees --table departments_copy --alter="engine=innodb" --allow-on-master --execute 2018/11/15 00:18:40 binlogsyncer.go:107: [info] syncer is closing... |
Same error on 1.0.47 |
Any updates on this issue? |
No updates; unfortunately I do not have the spare cycles to investigate this right now. |
Understandable, thanks for the update. |
I've ran into the same issues mentioned above and reproduced in an AWS environment (gist here): basically it does have something to do with MySQL 8 because MySQL 5.7 works. Digging deeper, it seems that in the 1.0.47 version of gh-ost released in October 2018, the MySQL toolset (https://github.com/siddontang/go-mysql) used under the hood had some issues with MySQL 8 - handling the new default authentication for one, and possibly others. However, there's been updates that were merged in December, and I presume that got pulled into this project at the beginning of the year (I'm new to Golang, but is there a way to see what specific version is vendored into this project? How are dependencies managed in this project/in general?). Building gh-ost from master and running a migration on MySQL 8 RDS seems to be working where the 1.0.47 release is failing with the EOF error. |
Thank you so much for testing this!
Ahem. I gave up on multiple vendoring/versioning approaches and right now vendoring is unversioned. To be clear, this is not the right way to go. Also, I'm yet to gain trust in a golang dependency manager. |
I'll make a release shortly, I hope. |
Hoping to give this a test-run today. Thanks for the investigation @alextsui05! |
Confirming building from master works as expected ( Hitting a snag on obtaining a lock at the final stages of switching, but that is not relevant to this issue. |
The release is a bit more of a hassle to generate, seeing that there is now CGO involved in the underlying |
For what it's worth, I'm hitting a (likely) mysql 8 related issue here. Something weird going on with column statistics locks. |
I try gh-ost 1.0.47 on mysql version 5.6.23 for the first time. the log is: 2019-02-15 10:32:13 INFO rotate to next log from mysql-bin.000239:0 to mysql-bin.000239 the error is about what? need some configure of mysql be changed ?@shlomi-noach |
I can confirm the 1.0.48 release resolves the binlogstreamer.go error with mysql 8.0.11 during my testing with dbdeployer. I am however now hitting the cutover issue described here. I'll comment further on that thread... Thanks much! |
Same error on 1.0.48 gh-ost: 1.0.48
|
Same error on 1.0.48
|
This is happening in 1.1.4 which uses old version of mysql library. I'm not sure the upgrade would fix it.. but can we get a new release with that change? |
MySQL [test]> select version(); MySQL [test]> show create table rds_table_01 \G #gh-ost --version execute shell : log: Migrating
|
hello,shlomi-noach
I am testing gh-ost latest GA version 1.0.45, still see:
binlogstreamer.go:47: [error] close sync with err: sync is been closing...
Check the issue list and notice that this issue is mentioned in #383, #388 and is fixed by #389 (no release yet)
When will it be released? thank you very much
The text was updated successfully, but these errors were encountered: