-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accepting --assume-rbr
, remove SUPER
requirement
#156
Conversation
- avoiding need to restart replication - in turn avoiding need for SUPER
Normally I would call this 👍 |
Hi @shlomi-noach, have you considered the approach of detecting whether Something like this:
If the event arrives as a This may be out of scope of the actual PR, and I can open an issue if you prefer to have the discussion there. PS. Kudos on coming up with such a novel approach to live schema changes. |
@pbitty this is a good suggestion, thank you! It may complicate stuff a bit, but seems worthwhile. I think I might first iterate with |
@SuperQ |
Maybe we can file a feature request upstream to extend the SHOW SLAVE STATUS to include the binlog mode for the running thread. |
👍 Nice |
Noting down that in the event I'm actually good to merge this, and iterate later with double-safety checks, such as:
|
Need to add documentation:
|
- introducing --assume-rbr - discussing the implication of being able to run without SUPER
--assume-rbr
--assume-rbr
, remove SUPER
requirement
Related issue: #132
Avoid restarting replication, avoid need for SUPER
gh-ost
cannot verify the replication thread truly usesRBR
, and wishes to restart replication (stop slave; start slave;
). However that requiresSUPER
privilege.This PR supports
--assume-rbr
where the user clearly indicates "yes, this is truly and really RBR, and the replica is using RBR". Ifbinlog_format=ROW
thengh-ost
is happy to proceed without restarting replication, hence without requiringSUPER
privilege.This PR [briefly explain what is does]
gofmt
(please avoidgoimports
)./build.sh