Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sleeping 500ms after 'START SLAVE' #337

Merged
merged 2 commits into from
Dec 15, 2016
Merged

sleeping 500ms after 'START SLAVE' #337

merged 2 commits into from
Dec 15, 2016

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Dec 13, 2016 •
edited
Loading

Storyline: #335

Immediately following START SLAVE command, gh-ost sleeps for 500ms to allow the replica the time to connect to its master.
Otherwise, if SHOW SLAVE STATUS is immediately executed after START SLAVE, the Slave_IO_thread can still be in Connecting state, which is interpreted as "oh replication isn't running".

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code is built via ./build.sh
  • code is tested via ./test.sh

@shlomi-noach shlomi-noach deployed to production/ghost-mysql001 December 14, 2016 09:33 Active
@shlomi-noach shlomi-noach merged commit 863f508 into master Dec 15, 2016
@shlomi-noach shlomi-noach deleted the start-slave-wait branch December 15, 2016 06:58
@shlomi-noach shlomi-noach mentioned this pull request Dec 23, 2016
Closed
This was referenced Jun 11, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shlomi-noach