Modified comment on Asset meta data ignore to better explain usage. #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokuhira
pushed a commit
to tokuhira/gitignore
that referenced
this pull request
Dec 16, 2019
r2pgl
pushed a commit
to r2pgl/gitignore
that referenced
this pull request
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
If used as written, the ignore rule in question will include .meta files in the repository even if the corresponding asset is ignored, which will cause issues in the editor. While there is no better ignore rule that applies more generally, at least noting in the comment that all ignored assets should also have their corresponding .meta file ignored as well will help users to avoid trouble.