Write updated licenses from SPDX directly to spdxlicenses package #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
commented
Jun 4, 2024
| @@ -43,61 +42,54 @@ func extractLicenseIDs() error { | |||
| return err | |||
| } | |||
|
|
|||
| // create two slices of license IDs, one for deprecated and one for not deprecated | |||
| // create two slices of license IDs, one for deprecated and one for active | |||
| var activeLicenseIDs []string | |||
There was a problem hiding this comment.
This was nonDeprecatedLicenseIDs. Updated the var name to activeLicenseIDs` as it is a better description of what the var holds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this PR, the extract script would get the latest official SPDX licenses update the licenses in text files in the
cmddir where the script was run. It created the list of licenses in the format used inspdxexp/spdxlicensesfunctions (i.e.GetLicense(),GetExceptions(),GetDeprecated()). The lists were copied manually to each of these functions.This PR avoids the need for manually updating the functions by having the extract script rewrite the files under
spdxexp/spdxlicensesdirectly to update the functions with the new list of SPDX licenses.At this point, the script still has to be called manually, but it is moving toward being run nightly by an action.