Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix website structure #96

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Fix website structure #96

merged 4 commits into from
Oct 10, 2023

Conversation

iansan5653
Copy link
Member

The GitHub Pages site unexpectedly places all HTML files under the pages path (ie, https://github.github.io/hotkey/pages/hotkey_mapper.html). In addition, there's a syntax error in the mapper script causing it not to work.

This fixes this by keeping the HTML files at the root and importing the JS using ./hotkey instead of ../dist. Also adds a reusable new script npm run buildSite for moving the files to the right place (to make it easier to test locally), and fixes the syntax error in the mapper demo.

@iansan5653 iansan5653 requested a review from a team as a code owner October 10, 2023 18:51
@iansan5653 iansan5653 merged commit 3353f4a into main Oct 10, 2023
2 checks passed
@iansan5653 iansan5653 deleted the fix-pages branch October 10, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants