Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeler fails when issue body is empty #33

Closed
eaftan opened this issue Feb 14, 2022 · 0 comments · Fixed by #34
Closed

Labeler fails when issue body is empty #33

eaftan opened this issue Feb 14, 2022 · 0 comments · Fixed by #34

Comments

@eaftan
Copy link
Contributor

eaftan commented Feb 14, 2022

When I attempt to use this labeler to label a new issue with an empty body, I get the following error message: "Could not get issue number or issue body from context, exiting".

We often turn task list entries into issues, and they are created with an empty body with no way to enter one. So the labeler fails whenever we do that.

eaftan added a commit to eaftan/issue-labeler that referenced this issue Feb 14, 2022
Previously the code was checking whether `issue_body` was falsy.
The empty string is considered falsy, which would make this Action
fail when the issue body was empty.  Instead, explictly compare
against `undefined` and tolerate issues with empty bodies.

Fixes github#33
stephanmiehe pushed a commit that referenced this issue Mar 6, 2022
Previously the code was checking whether `issue_body` was falsy.
The empty string is considered falsy, which would make this Action
fail when the issue body was empty.  Instead, explictly compare
against `undefined` and tolerate issues with empty bodies.

Fixes #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant