[Bundler] Don't use Bundler.default_*file to find gem file and lock file #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using these methods has undesirable effects - raises an error if a file can't be found - `ENV["BUNDLE_GEMFILE"]` overrides file search - potential mismatch in gem file name
dbussink
reviewed
Apr 6, 2018
| # block. we shouldn't need to restore these values manually | ||
| BUNDLER_ENV_KEYS.each { |k| ENV.delete(k) } | ||
| # force bundler to use the local gem file | ||
| ENV["BUNDLE_GEMFILE"] = gemfile_path.to_s |
There was a problem hiding this comment.
@jonabc Should this ENV var be unset in the ensure block below? Otherwise this method that takes a block leaks that environment variable?
There was a problem hiding this comment.
@dbussink It's not necessary and won't leak because ::Bundler.with_original_env captures and restores the full ENV object itself.
👍 to restoring the ENV var in the ensure block to be more explicit and avoid confusion though.
There was a problem hiding this comment.
Ah, thanks! Yeah, explicitly doing it is nice I think.
eileencodes
reviewed
Apr 6, 2018
test/source/bundler_test.rb
Outdated
| @@ -1,13 +1,22 @@ | |||
| # frozen_string_literal: true | |||
| require "test_helper" | |||
| require "tmpdir" | |||
| require "byebug" | |||
There was a problem hiding this comment.
You left byebug in here 😄
make some implicit functionality explicit
dbussink
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Fixes #24
Fixing a couple issues where
::Bundler.default_*filedoes not behave ideally for usage in licensedENV["BUNDLE_GEMFILE"]over searching for a gem file in the local file hierarchyENV["BUNDLE_GEMFILE"]doesn't match the name of the file in the configured app source path (gems.rb vs Gemfile)Bundler::SharedHelpers::find_gemfileThe downside is that now the source has to either keep track of the possible gem file names itself or call the private
Bundler::SharedHelpers::gemfile_names. This PR opts to keep track of the file names locally so that licensed doesn't take a dependency on a private method that could change without notice.