Find packages from Nuget fallback folders if possible #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ raise error if json can't be parsed + set dependency error if path isn't found based on solution by paveliak from #273
|
@zarenner 👋 can you review this PR? I'm pretty confident it should be ok, but the sanity check on nuget usage and patterns as well as the extra set of eyes would be appreciated! |
zarenner
reviewed
Jun 11, 2021
lib/licensed/sources/nuget.rb
Outdated
| id = "#{name}-#{version}" | ||
|
|
||
| path = full_dependency_path(reference_key) | ||
| error = "Package #{id} not found at any project package folder" if path.nil? |
There was a problem hiding this comment.
Won't path also be nil if for some reason it's missing under libraries -> reference_key -> path? Not a big deal but the error will be slightly incorrect.
There was a problem hiding this comment.
(feel free to ignore, I don't think this is important enough to differentiate on, but perhaps you want to clarify the message)
zarenner
approved these changes
Jun 11, 2021
|
lgtm! |
jonabc
added a commit
that referenced
this pull request
Jun 16, 2021
## 3.1.0 2021-06-16 ### Added - Licensed supports Swift/Swift package manager as a dependency source (:tada: @mattt #363)' ### Changed - The `source_path` configuration property accepts arrays of inclusion and exclusion glob patterns (#368) - The Nuget source now uses configured fallback folders to find dependencies that are not in found in the project folder (#366) - The Nuget source supports a configurable property for the path from the project source path to the project's `obj` folder (#365) ### Fixed - The Go source's checks for local packages will correctly find paths in case-insensitive file systems (#370) - The Bundler source will no longer unnecessarily reset the local Bundler environment configuration (#372)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #352
This gives an alternate solution to #273. I opted to start a new branch because that PR/branch had become stale and it was a bit quicker to build on the ideas rather than building directly on the code.
I've given attribution to @paveliak in the commit comment, and here as well I guess 😄 . @paveliak if there's another way you'd like me to represent your input in these changes please let me know 🙏 !
Some other changes that came along as I better understood the json file format and the code here:
Licensed::Sources::Source::Errorerror if the json file can't be parsed. This is a special error class that signals a source enumerator-wide error.nil, which doesn't work with the default scenario.Setto enforce uniqueness, though now the uniqueness is enforced forreference_keyvalues and not computedidvalues.