Do not delete skipped sources' cache #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent refactor I introduced a bug where setting
licensed cache --source <source>would unintentionally delete the cached files from all other sources 🤦 .The underlying issue came from moving the check on whether a source was skipped into the base command class. When the check was moved there was no longer any indication that the cache path shouldn't be cleaned for unused dependencies, and because no dependencies from the source were evaluated they are all determined to be unused.
This change has the base command implementation return a symbol
:skippedinstead of true, so that sources extending the default behavior are aware of this case. The symbol is truthy and will result in the source evaluation being considered a success