Replace Array#sum with Array#reduce #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonabc
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
👍 thanks for fixing this! if this is all that's needed for 2.3 support then 
.
As an FYI, I'm not sure whether further/deeper changes would be desirable in the name of supporting older ruby versions. Generally the minimum bar for support in licensed is tied to the underlying tools/languages/frameworks, and in this case the oldest non-EOL version of ruby is 2.6
jonabc
added a commit
that referenced
this pull request
Dec 14, 2021
## 3.4.0 2021-12-14 ### Added - New Yarn enumerator with support for berry versions (#423) ### Fixed - Error handling cases return correct values in the Yarn enumerator (#425) - Fixed link in command documentation (:tada: @chibicco #416) - Fixed minor backwards compatibility issue for Ruby 2.3 support (:tada: @dzunk #414) ### Changed - Licensed's own dependencies are cached in the repository and kept up to date with GitHub Actions (#421)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores compatibility with Ruby 2.3 by replacing the
Array#summethod that was introduced in Ruby 2.4. Fixes #413.Not sure what the appetite is for maintaining legacy compatibility, but if it's worth releasing a new version for it, here's the fix.