Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pnpm source for dependency enumeration #626

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Add pnpm source for dependency enumeration #626

merged 2 commits into from
Feb 8, 2023

Conversation

jonabc
Copy link
Contributor

@jonabc jonabc commented Feb 8, 2023

Closes #625

This adds in basic support for to use pnpm as a source to enumerate dependencies. The source uses the experimental (as of this writing) pnpm licenses list CLI command to enumerate data. The only quirk with this source is that as far as I can tell there's no way to find dependencies individually per workspace project in repositories using pnpm workspaces. Otherwise the source is very straightforward.

This PR includes everything needed to develop and test the source

  • the source itself
  • tests and test fixtures
  • a source bootstrap script
  • an entry in the tests GitHub Action workflow
  • basic documentation about the source

@RobbieTheWagner
Copy link

This is awesome, thank you @jonabc!

@jonabc
Copy link
Contributor Author

jonabc commented Feb 8, 2023

I'm ignoring the cabal test failures for this change. Those test failures are coming from an issue during the setup phase of the tests and are almost certainly unrelated to adding this new dependency source.

@jonabc jonabc merged commit aa1eb3e into master Feb 8, 2023
@jonabc jonabc deleted the pnpm-source branch February 8, 2023 15:59
jonabc added a commit that referenced this pull request Feb 8, 2023
### Added

- Custom license terms can be added to dependencies via new configuration options (#624)
- Licensed is now integrated with pnpm to enumerate dependencies (#626)
@jonabc jonabc mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for pnpm as a source
2 participants