Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring reviewed and ignored dependencies at specific versions #629

Merged
merged 6 commits into from
Feb 22, 2023

Conversation

jonabc
Copy link
Contributor

@jonabc jonabc commented Feb 20, 2023

This builds off of the configuration changes made in #560 to bring in full support for configuring reviewed and ignored dependencies that include version identifiers.

Version identifiers are given by adding @... to the end of dependency names in the reviewed and ignored configuration lists. Identifiers can have the following values:

  1. * - explicitly match all versions
  2. a value that can be parsed by Gem::Requirement provides support for version ranges - (=|<|<=|>|>=|~>) 1.2.3. For non-Ruby devs, the ~> is called the twiddle-waka and is a pessimistic matcher similar to node's tilda range operator.
    • Multiple ranges can be specified as a single string separated by commas - dependency@>= 1.0.0, < 2.0.0
  3. a value that can't be parsed by Gem::Requirement will be compared with an exact string match to a found dependency's version

This mostly affects the pnpm source at the moment, which requires reviewing and ignoring dependencies using @.... For other sources, the change is expected to be backwards compatible and users should only expect changes when configuring dependencies at specific versions or specific version ranges.

@jonabc
Copy link
Contributor Author

jonabc commented Feb 22, 2023

The gradle failures are related to a current Gradle version bump to 8.0.1 in CI, and not directly attributed to anything done here. I've put together a potential fix for that separately. I'm going to merge this as-is, and when the gradle fix is looking alright both changes can be released with a minor version bump to licensed.

@jonabc jonabc merged commit f72e3d1 into master Feb 22, 2023
@jonabc jonabc deleted the reviewed-and-ignored-at-versions branch February 22, 2023 20:29
jonabc added a commit that referenced this pull request Feb 25, 2023
### Added
- Reviewed and ignored configuration lists support matching on versions and version ranges (#629)

### Fixed
- Licensed should more reliably source dependencies from Gradle >= 8.0 (#630)
@jonabc jonabc mentioned this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant