-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Racket color based on new logo #3815
Conversation
Some time ago, the Racket folks updated their logo as part of the rebranding from PLT Scheme. You can see the new logo here: https://github.com/racket/icons/blob/master/racket-logo.svg. Racket is a great language and deserves a cool GitHub color to match their logo. Also, Haskell's color was recently changed from green to purple: #3728. We don't want people to think Haskell is the only functional programming game in town.
Unfortunately this PR can't be merged yet as it's not passing CI because the colour you've chosen is too similar to that used by another language. You're going to need to experiment with the colour until you find one that didn't conflict. I understand this may be quite a challenge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're going to change the threshold, please do some thorough tests and justify why this is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also gonna have to stop you now. Increasing the threshold to satisfy your colour selection is not the best approach (it's also the wrong way round) as you can see from the ever increasing number of conflicts being reported in the subsequent tests.
Take a look at the colours reported in the initial failure:
#3e5ba9
(your chosen colour)
#375eab
#4F5D95
#3e5ba9
As you can see, they're all very very close and not easily distinguishable.
You need to adjust your chosen colour, not the threshold.
No problems, though you'll find it much easier to test this stuff on an actual computer 😉
I saw that.
Indeed. Blue is incredibly popular and it is for this reason we've had to implement this threshold test and it's why, if you're going to want a shade of blue, you're going to have to pick another.
(I cunningly changed the proportions between the two screenshots to make guessing the breakpoint harder 😉) Why not keep the current colour Or how about a variant of the red (
Indeed there are an increasing number of languages and conflicts do occur, however we (the Linguist community) can't unilaterally decide on lowering the threshold without a full and comprehensive analysis of the languages on GitHub and how such a change would impact the overall appearance of the language statistics bar on GitHub.com, especially when there are a lot of unused, and significantly more unique, colours still available. Not every language has a colour directly associated with their logo or website colours as a deliberate choice to make it more unique on GitHub, that's also an option. |
In #3815, I wanted to update the Racket color to match the blue color used in the logo. Unfortunately, Go was very close in the colorspace. In #4331, Go was changed to a lighter blue. Now, with a minor tweak, the Racket color can be successfully updated from `#22228f` to `#3c5caa`. This won't turn out like the #4319 (Rust) debacle for the following reasons: - The blue color is official, not just a random opinion. - We are going from a dark and not easily visible shade of blue to a lighter shade of the same color. - Racket is not as popular as Rust, so an army of Reddit users will not show up armed with negative emojis. Of course, if a Racket developer shows up and explains why this is a disaster, it will be easy enough to revert. But I think a nicer color will help Racket, an underappreciated Lisp dialect, look more attractive.
No description provided.