Output <code> instead of <tt> for inline literals in rst files #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hah! Great catch. /cc @github/user-content N.B. that the removal of classes ( |
gjtorikian
added a commit
that referenced
this pull request
Nov 21, 2014
Output <code> instead of <tt> for inline literals in rst files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering inline literals in rst,
<tt>is output by rest2html, because that's what docutils generally does. The renderer for every other format outputs<code>for inline literals. Not accounting for<tt>results in emoji being inserted into rst inline literals, an issue which I also submitted a pull request for here