rest2html: Add support for highlight directive #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping. |
|
Hello? |
kivikakk
reviewed
Mar 16, 2017
lib/github/commands/rest2html
Outdated
| else: | ||
| self.body.append(self.starttag(node, 'pre')) | ||
|
|
||
| def visit_highlight(self, node): |
There was a problem hiding this comment.
I have no idea about rST, so forgive me if I'm missing the mark, but should this definition be here? It looks like we don't output to stdout at any other time except when returning from main().
alikkille
suggested changes
May 27, 2017
lib/github/commands/rest2html
Outdated
| else: | ||
| self.body.append(self.starttag(node, 'pre')) | ||
|
|
||
| def visit_highlight(self, node): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This adds support for the `highlight` directive, a Sphinx feature which allows one to set the default syntax highlighting language used for code blocks.
|
Fixed. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
highlightdirective, a Sphinx feature whichallows one to set the default syntax highlighting language used for code
blocks.
This fixes #924.