Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiera setup simplification #17

Merged
merged 9 commits into from
Nov 7, 2016
Merged

Conversation

kpaulisse
Copy link
Contributor

@kpaulisse kpaulisse commented Nov 4, 2016

Overview

This pull request changes the defaults for the Hiera configuration to match the Puppet control repo template and the default installation of Puppet Enterprise.

It also introduces a new option --hiera-path PATH to specify the relative path to hieradata. This passes through the relative directory to the munged hiera.yaml file. This is an alternative to --hiera-path-strip PATH which will reference the settings from the existing hiera.yaml file and subtract the specified path. Since most humans tend to find a positive declaration easier than a negative one, this should simplify the setup for many people.

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended.

@kpaulisse kpaulisse mentioned this pull request Nov 7, 2016
@kpaulisse kpaulisse merged commit 7cf8f64 into master Nov 7, 2016
@kpaulisse kpaulisse deleted the kpaulisse-hiera-simplification branch December 30, 2016 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant