Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request changes the defaults for the Hiera configuration to match the Puppet control repo template and the default installation of Puppet Enterprise.
It also introduces a new option
--hiera-path PATH
to specify the relative path to hieradata. This passes through the relative directory to the munged hiera.yaml file. This is an alternative to--hiera-path-strip PATH
which will reference the settings from the existing hiera.yaml file and subtract the specified path. Since most humans tend to find a positive declaration easier than a negative one, this should simplify the setup for many people.Checklist
rake
in your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:spec
or ignoring untestable sections of code with# :nocov
comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.