Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll 3.0.x #175

Merged
merged 27 commits into from
Feb 1, 2016
Merged

Jekyll 3.0.x #175

merged 27 commits into from
Feb 1, 2016

Conversation

benbalter
Copy link
Contributor

This is a progress tracking branch for getting things where the GitHub Pages Gem could be bumped to use Jekyll 3.0.x and related dependencies.

Initial todo to establish a baseline of what's changed:

  • Get the Gemfile to bundle
  • Confirm plugins work on 3.x
    • jemoji
    • jekyll-mentions
    • jekyll-redirect-from
    • jekyll-sitemap
    • jekyll-feed
  • Enumerate breaking changes

Known breaking changes

  • Dropped support for Ruby < 2.0
  • Rouge is now the default highlighter
  • Coffeescript and paginate must be explicitly included
  • Dropped Maruku support

Please contribute only constructive comments below. If you would like to follow the effort's progress, you may click subscribe in the right-hand sidebar.

This was referenced Oct 27, 2015
@benbalter benbalter modified the milestone: Jekyll 3.0.x Oct 27, 2015
@parkr
Copy link
Contributor

parkr commented Oct 27, 2015

🙏

@parkr
Copy link
Contributor

parkr commented Oct 28, 2015

@benbalter jekyll-redirect-from has been updated: https://github.com/jekyll/jekyll-redirect-from/releases/tag/v0.9.0

@parkr
Copy link
Contributor

parkr commented Oct 28, 2015

@benbalter Also, see jekyll/jekyll#3945 for a list of gems that have been CI'd against Jekyll 3.

@benbalter
Copy link
Contributor Author

Thanks @parkr looks like just mentions and jemoji then, which have fixes in the works.

@parkr
Copy link
Contributor

parkr commented Nov 1, 2015

@benbalter Did you add jekyll-paginate?

@benbalter
Copy link
Contributor Author

Did you add jekyll-paginate?

Added.

"jekyll-coffeescript" => "1.0.1",
"jekyll-sass-converter" => "1.3.0",
"jekyll-paginate" => "1.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both jekyll-paginate and jekyll-coffeescript can be moved down to "Plugins" as they're no longer runtime dependencies of Jekyll. :)

@parkr
Copy link
Contributor

parkr commented Nov 2, 2015

Marvelous!

* master:
  💎 bump
  bump to 2.1.7-github
  bump jekyll-seo to 0.1.4
  add jekyll-seo-tag
  try 2.3.0
  try ruby 2.0-2.3
@alexconst
Copy link

Considering the work being done here, would it be worth submitting a fix to jekyll's issue with (the lack of) bold text on firefox?
(And there is also the issue with the header sizes, like h2 font being bigger than h1)
Which would eventually bump jekyll to 2.4.1 and would eventually be adopted by github.
I have no clue on the progress timeline for these things.

FWIW, test case for both bugs (visible in firefox):

---
layout: post
title:  "Test case"
date:   2016-01-10 21:44:44
categories: jekyll update
---

# header 1

test

## header 2

test

### header 3

testing **bold text here**

@j-mes
Copy link

j-mes commented Jan 11, 2016

@alexconst Wouldn't this be more of a CSS issue than Jekyll itself?

@alexconst
Copy link

@j-mes Well, it's the CSS produced by Jekyll using its site_template. But I get your point.
And since the solution is already documented I guess it's not really worthwhile.

@benbalter
Copy link
Contributor Author

Just a quick update for those following along, this effort is still very much on track, and should be available at a GitHub Pages site near you in the coming month.

In the interim, if you'd like to test your site against the GitHub Pages Jekyll 3 stack, see @parkr's excellent post over in https://talk.jekyllrb.com/t/jekyll-3-x-with-github-pages/1832.

@larryfox
Copy link

@benbalter Is it safe to assume Github pages will be targeting 3.1.x now, since that's been released in the interim?

@parkr
Copy link
Contributor

parkr commented Jan 26, 2016

@larryfox: no, v3.0.1 is currently targeted. 3.1 will come later.

@benbalter
Copy link
Contributor Author

Is it safe to assume Github pages will be targeting 3.1.x now, since that's been released in the interim?

There are a lot of moving parts in 3.1 (specifically drops), with few user-facing features other than performance. We're focusing on getting folks happy on 3.0.x, and then can come back and take a look at 3.x in another pass. This will also give 3.1 some time to bake in the wild.

@larryfox
Copy link

Understandable, thanks for the clarification!

@ghost
Copy link

ghost commented Feb 1, 2016

I think there is a problem with Kramdown or Rouge:

Before:

source 'https://rubygems.org'
gem "github-pages"

capture d ecran 2016-02-01 a 02 15 05


After:

source 'https://rubygems.org'
gem "github-pages", github: "github/pages-gem", branch: "jekyll-3"

capture d ecran 2016-02-01 a 02 13 57


I use Prismjs for the highlighting, so it is based on classes of <pre>
The highlighting is now broken because the language is not being used in the class

I use

kramdown:
  input: GFM

capture d ecran 2016-02-01 a 02 20 35

benbalter added a commit that referenced this pull request Feb 1, 2016
@benbalter benbalter merged commit f2f660a into master Feb 1, 2016
@benbalter benbalter deleted the jekyll-3 branch February 1, 2016 16:06
@vdclouis
Copy link

vdclouis commented Feb 1, 2016

w00p!

@pathawks
Copy link
Contributor

pathawks commented Feb 1, 2016

🎉 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants