Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't ignore Gemfile.lock for deterministic builds #829

Conversation

dijonkitchen
Copy link

@dijonkitchen dijonkitchen commented Apr 8, 2022

@dijonkitchen dijonkitchen mentioned this pull request Apr 8, 2022
4 tasks
@fulldecent
Copy link
Contributor

This PR seems to make a failed assertion.

When GitHub Pages builds a website (not talking about GitHub Actions) it does NOT use the Gemfile.lock to find what versions to build with.

It means that GitHub Pages' infrastructure decides which versions of Jekyll/Ruby/... it is running, not you.

This PR does not change that behavior of how GitHub Pages infrastructure works.

So if this is PR is accepted, then the test suite will run against new versions of Jekyll/Ruby/... rather than the version that production uses.

If my understand is correct here, we should NOT merge this PR.

@parkr
Copy link
Contributor

parkr commented Sep 18, 2023

RubyGems do not ship with their Gemfile.lock files. The guidance you linked to is for end users. There is no way for an end user to use the Gemfile.lock from a RubyGem.

@dijonkitchen dijonkitchen deleted the build-gemfile-lock-determinism branch January 18, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants