-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jekyll-redirect-from to 0.6.0 #88
Conversation
@shawndavenport @mastahyeti for 👀 just in case you didn't get the team mention above. |
Seems okay. |
Bump jekyll-redirect-from to 0.6.0
@parkr @benbalter At your leisure could I get added to the release rights for this gem? Or could you push a new release? ❤️ ❤️ ❤️ |
My leisure? Immediately. Release away!
|
I just found out that my redirects are broken because of the issue I mentioned here on the PR for bumping jekyll-redirect-from to v0.5.0: #86 (comment) @parkr It's a bit disappointing that you simply closed the other PR and made a new one without at least giving me a heads up. |
I'm sorry – I can't manage who is depending upon which PR. You'll see that it was closed, not merged, so the changes are not reflected in the codebase. |
@parkr the issue is that the changes are now in the codebase as this PR included the 0.5.0 changes, breaking my redirects. All I was asking for was to delay this until GitHub Pages fixes the CNAME bug, sorry if I sounded a bit harsh 😄 Anyway, it's not your fault, I'll poke GitHub's support again on the status of the bug fix. |
Sorry – I didn't realize that the problem wasn't addressed. GitHub Support should be able to help you out – I believe @azizshamim or @benbalter should be able to get this sorted for you. |
Bumping from
0.4.0
to0.6.0
. Release notes for each version:v0.5.0
v0.6.0
The full diff: jekyll/jekyll-redirect-from@v0.4.0...v0.6.0
Nothing I can identify that would be a security concern. The only new functionality:
site.baseurl
orsite.github.url
/cc @gjtorikian @kansaichris @benbalter @github/security