Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jekyll-redirect-from to 0.6.0 #88

Merged
merged 1 commit into from
Aug 26, 2014
Merged

Bump jekyll-redirect-from to 0.6.0 #88

merged 1 commit into from
Aug 26, 2014

Conversation

parkr
Copy link
Contributor

@parkr parkr commented Aug 22, 2014

Bumping from 0.4.0 to 0.6.0. Release notes for each version:

The full diff: jekyll/jekyll-redirect-from@v0.4.0...v0.6.0

Nothing I can identify that would be a security concern. The only new functionality:

  1. Preface the URL in the HTML (doesn't affect the output directory/filename) with site.baseurl or site.github.url
  2. Gives collection documents access to existing functionality (nothing new here)

/cc @gjtorikian @kansaichris @benbalter @github/security

@kansaichris
Copy link

@shawndavenport @mastahyeti for 👀 just in case you didn't get the team mention above.

@btoews
Copy link

btoews commented Aug 25, 2014

Seems okay.

gjtorikian added a commit that referenced this pull request Aug 26, 2014
Bump jekyll-redirect-from to 0.6.0
@gjtorikian gjtorikian merged commit 3ae5250 into github:master Aug 26, 2014
@gjtorikian
Copy link
Contributor

@parkr @benbalter At your leisure could I get added to the release rights for this gem? Or could you push a new release? ❤️ ❤️ ❤️

@parkr parkr deleted the redirect-from-bump branch August 26, 2014 06:04
@parkr
Copy link
Contributor Author

parkr commented Aug 26, 2014

My leisure? Immediately. Release away!

~$ gem owner github-pages --add gjtorikian@********
Owner added successfully.
Owners for gem: github-pages
- gjtorikian@********
- ben.balter@********
- parkrmoore@********

☺️

@akoeplinger
Copy link

I just found out that my redirects are broken because of the issue I mentioned here on the PR for bumping jekyll-redirect-from to v0.5.0: #86 (comment)

@parkr It's a bit disappointing that you simply closed the other PR and made a new one without at least giving me a heads up.

@parkr
Copy link
Contributor Author

parkr commented Sep 2, 2014

@parkr It's a bit disappointing that you simply closed the other PR and made a new one without at least giving me a heads up.

I'm sorry – I can't manage who is depending upon which PR. You'll see that it was closed, not merged, so the changes are not reflected in the codebase.

@akoeplinger
Copy link

@parkr the issue is that the changes are now in the codebase as this PR included the 0.5.0 changes, breaking my redirects. All I was asking for was to delay this until GitHub Pages fixes the CNAME bug, sorry if I sounded a bit harsh 😄

Anyway, it's not your fault, I'll poke GitHub's support again on the status of the bug fix.

@parkr
Copy link
Contributor Author

parkr commented Sep 2, 2014

Sorry – I didn't realize that the problem wasn't addressed. GitHub Support should be able to help you out – I believe @azizshamim or @benbalter should be able to get this sorted for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants