Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logic for determining list position #32

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

nicolleromero
Copy link
Contributor

@nicolleromero nicolleromero commented Aug 25, 2022

Fixes https://github.com/github/issues-graph/issues/825

This PR adjusts the logic used to calculate the positioning of lists within a comment to satisfy additional ul and ol usage.

See linked issue for additional context.

@mr-mig
Copy link
Contributor

mr-mig commented Aug 25, 2022

You may want to double-check these combos:

  • Nested tasklists
  • Nested mixes of checklists and tasklists
  • Tasklists/checklists within HTML tables (not MD tables)
  • Nested tasklists within HTML tables

@nicolleromero
Copy link
Contributor Author

You may want to double-check these combos:

  • Nested tasklists
  • Nested mixes of checklists and tasklists
  • Tasklists/checklists within HTML tables (not MD tables)
  • Nested tasklists within HTML tables

Tested the above to confirm that no functionality was lost. The current implementation of a tasklist remains encapsulated so shouldn't be adversely affected by the new positioning logic when support for nesting w/in tasklists is added. 👍

@nicolleromero nicolleromero marked this pull request as ready for review August 25, 2022 19:31
@nicolleromero nicolleromero requested a review from a team as a code owner August 25, 2022 19:31
@dgreif dgreif merged commit b4df6e4 into main Aug 26, 2022
@dgreif dgreif deleted the update-check-for-position branch August 26, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants