Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout during query compilation or query evaluation should produce notification #251

Closed
henrymercer opened this issue Feb 26, 2020 · 0 comments · Fixed by #266
Closed
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@henrymercer
Copy link
Contributor

Describe the bug
If a query compilation or a query evaluation times out, the extension should produce a notification to inform the user of the timeout.

To Reproduce

  1. Set codeQL.runningQueries.timeout to 1 second
  2. Run a long-running query e.g. a path problem query
  3. Observe that the query run notification disappears, indicating that the query run has terminated, however there is no notification informing the user of the timeout.

Expected behavior
When the query run notification disappears, an error notification should be displayed indicating that the query run has timed out.

@henrymercer henrymercer added bug Something isn't working good first issue Good for newcomers labels Feb 26, 2020
@aeisenberg aeisenberg self-assigned this Mar 5, 2020
aeisenberg added a commit to aeisenberg/vscode-codeql that referenced this issue Mar 6, 2020
Also, add the message to the log.

Closes github#251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants