-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to get dftfringe to compile for a mac #24
Comments
(Link to groups for historical reasons https://groups.io/g/Interferometry/topic/99192778) I would like to add the CI for macOS. I also planned to add CD for supported platforms but my CI proposals need to be merged firsts. (Is there any plan to merge them ? Or are more explanations needed ? It's too disruptive ? => maybe wrong thread to answer this) |
George you can take over and do any merging needed. I don't have any updates that I remember and am very busy with other things. Do you need any additional permissions?
Dale
… On 05/29/2023 12:24 AM CDT Julien Staub ***@***.***> wrote:
(Link to groups for historical reasons https://groups.io/g/Interferometry/topic/99192778)
I would like to add the CI for macOS.
I also planned to add CD for supported platforms but my CI proposals need to be merged firsts. Is there any plan to merge them ? Or are more explanations needed ? It's too disruptive ?
—
Reply to this email directly, view it on GitHub #24 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2BJLG2YS2RKBBSFJPHRKDXIQXHHANCNFSM6AAAAAAYSINFQI.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
I will do that then. I should be all set. |
I've now uploaded a build of the macOS version here: https://groups.io/g/Interferometry/files/DFTFringe%20for%20macOS Consider it a beta, feedback welcome! I'll post the code changes shortly. This is going to be really hard to do the CI for, this app bundle was very 'handmade'!
|
Hi Dan, PS: I deleted my answer on groups.io to paste it here as it's about development. |
The way to solve "hard" is to take it one step at a time. Code changes are probably needed first. I believe there are at least 2 very common and active versions of mac software? Using different hardware technology? I'm not sure - I just hear crazy stories from other multi OS projects. |
I see you have libarmadillo.11.dylib in that zip file you uploaded. I'm pretty sure it's not needed. Curious if it still runs without that library. Dale claims he only uses armadillo for one structure. So only include files are needed. He was planning to use much more but changed his mind. The armadillo.dll file is not included in Dale's installer even though it is mentioned in the ".pro" file. I think @atsju can remove it from his installer as well but was going to test that before I told him that. Don't think we need to build armadillo either unless the build process is creating the .h files (sometimes you have to build the include files which is more of a copy operation really). |
This is a placeholder to discuss any changes needed to get DFTFringe to compile on a mac.
The text was updated successfully, but these errors were encountered: