Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to get dftfringe to compile for a mac #24

Open
gr5 opened this issue May 29, 2023 · 7 comments
Open

Changes to get dftfringe to compile for a mac #24

gr5 opened this issue May 29, 2023 · 7 comments

Comments

@gr5
Copy link
Collaborator

gr5 commented May 29, 2023

This is a placeholder to discuss any changes needed to get DFTFringe to compile on a mac.

@atsju
Copy link
Collaborator

atsju commented May 29, 2023

(Link to groups for historical reasons https://groups.io/g/Interferometry/topic/99192778)

I would like to add the CI for macOS.

I also planned to add CD for supported platforms but my CI proposals need to be merged firsts. (Is there any plan to merge them ? Or are more explanations needed ? It's too disruptive ? => maybe wrong thread to answer this)

@githubdoe
Copy link
Owner

githubdoe commented May 29, 2023 via email

@gr5
Copy link
Collaborator Author

gr5 commented May 29, 2023

I will do that then. I should be all set.

@Interferometry
Copy link
Contributor

Interferometry commented Jul 6, 2023

I've now uploaded a build of the macOS version here:

https://groups.io/g/Interferometry/files/DFTFringe%20for%20macOS

Consider it a beta, feedback welcome!

I'll post the code changes shortly. This is going to be really hard to do the CI for, this app bundle was very 'handmade'!

  ____  _____ _____ _____     _
 |    \|   __|_   _|   __|___|_|___ ___ ___
 |  |  |   __| | | |   __|  _| |   | . | -_|
 |____/|__|    |_| |__|  |_| |_|_|_|_  |___|
                                   |___|

DFTFringe 6.2 For macOS

- Universal build (Apple Silicon & Intel).
- Gatekeeper friendly, application has been signed and notarised.
- Requires macOS Ventura, or later.

INSTALLATION:

- Unzip the file and drag the DFTFringe app into the Applications folder.
- To uninstall, drag DFTFringe from the applications folder to Bin/Trash.

FEEDBACK:

Feedback is welcome, please post any issues with the macOS release to:

    GitHub : https://github.com/githubdoe/DFTFringe

MacOS specific DFTFringe issues can be reported here:

    GitHub : https://github.com/Interferometry/DFTFringe-macOS

Discussion group about interferometry, including DFTFringe here:

 Groups.io : https://groups.io/g/Interferometry

@atsju
Copy link
Collaborator

atsju commented Jul 6, 2023

Hi Dan,
I don't own a Mac, however I did setup the CI for windows and linux on GitHub. I now have a good view of the build process AND packaging with QT installer (which I choose because it's supposed to be multi-platform and support Mac).
I can help you setting up CI for Mac, do not hesitate to write some notes about how you built it on your own machine and it should be doable on CI.
Do not wait for perfection before pushing and opening a PR. It's better to discuss small changes along the road than having everything very rigid at the end of the process.
Thank you for your contribution !

PS: I deleted my answer on groups.io to paste it here as it's about development.

@gr5
Copy link
Collaborator Author

gr5 commented Jul 6, 2023

The way to solve "hard" is to take it one step at a time. Code changes are probably needed first.

I believe there are at least 2 very common and active versions of mac software? Using different hardware technology? I'm not sure - I just hear crazy stories from other multi OS projects.

@gr5
Copy link
Collaborator Author

gr5 commented Jul 6, 2023

I see you have libarmadillo.11.dylib in that zip file you uploaded. I'm pretty sure it's not needed. Curious if it still runs without that library.

Dale claims he only uses armadillo for one structure. So only include files are needed. He was planning to use much more but changed his mind.

The armadillo.dll file is not included in Dale's installer even though it is mentioned in the ".pro" file. I think @atsju can remove it from his installer as well but was going to test that before I told him that. Don't think we need to build armadillo either unless the build process is creating the .h files (sometimes you have to build the include files which is more of a copy operation really).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants