modified "about" window to get compiler, QT, openCV and armadillo version automatically #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gr5 I did a merge commit to avoid dismissing a potential review in progress but if you prefer I can rebase the branch to keep more linear commit history |
Great. Actually I can see the build is in progress now. I will build this on my own machine today just to double check everything and hope to merge this today. I'm in the middle of a bug fix right now so I'll commit that to my own personal branch first (or do a git stash) but I have errands this morning before that. |
gr5
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not perfect as armadillo version is got dynamically at runtime while other versions are static at compile time.
Next step could be to add windows/linux version from computer it's running on.
Also adding the sha of git commit where build comes from would be great to track issues (I know very few people use their own build but this might change a bit with Linux support)
On linux:
With the windows build from github actions
